logging: Fix cookie filter
#4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #4941 The implementation wasn't correct. Headers in logs are actually of type `caddyhttp.LoggableStringArray`, but the implementation was trying to read it from `in.String` which only works if the logged field is actually a string; it's not, so we need to use `in.Interface` and type assert it. The test was also incorrect for the same reason. I think the tests were written with the assumption that the logs actually work a certain way, but they don't in reality. Tested with the following Caddyfile, with this command `curl -v -H'Cookie: myvalue=1; sessionid=ST1LLh3r3' http://localhost:8883` ``` { debug admin off servers { log_credentials } } :8883 { log { format filter { wrap json fields { request>headers>Cookie cookie { replace sessionid REDACTED } } } } } ```
mholt
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4941
The implementation wasn't correct. Headers in logs are actually of type
caddyhttp.LoggableStringArray, but the implementation was trying to read it fromin.Stringwhich only works if the logged field is actually a string; it's not, so we need to usein.Interfaceand type assert it.The test was also incorrect for the same reason. I think the tests were written with the assumption that the logs actually work a certain way, but they don't in reality.
Tested with the following Caddyfile, with this command
curl -v -H'Cookie: myvalue=1; sessionid=ST1LLh3r3' http://localhost:8883