Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverseproxy: Add unix+h2c Caddyfile network shortcut #4953

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

francislavoie
Copy link
Member

As requested in #4498, just adding a little shorthand to make this work:

reverse_proxy unix+h2c//dev/shm/grpc

/cc @PaTTeeL

@francislavoie francislavoie added the feature ⚙️ New feature or request label Aug 12, 2022
@francislavoie francislavoie added this to the v2.5.3 milestone Aug 12, 2022
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do find it strange that h2c is set as a scheme and that unix+h2c is a network type, but it kinda makes sense. I can't think of a better alternate way to do it, so I guess we can go with this.

@francislavoie
Copy link
Member Author

Yeah, that's just kinda how the code was set up. We have the "Caddy network addresses" which map to Go's stuff, and then we have the scheme shortcuts for Caddyfile upstream addresses... and H2C + Unix is actually both of those.

I'm using + cause we have precedent with srv+https (although that's deprecated now with dynamic srv but I digress)

@francislavoie francislavoie merged commit e2a5e22 into master Aug 12, 2022
@francislavoie francislavoie deleted the unix-plus-h2c-caddyfile branch August 12, 2022 21:09
WilczynskiT pushed a commit to WilczynskiT/caddy that referenced this pull request Aug 17, 2022
@mholt mholt modified the milestones: v2.6.0-beta.1, v2.6.0 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants