Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddyhttp: Fix for nil handlerErr.Err #4977

Merged
merged 1 commit into from
Aug 23, 2022
Merged

caddyhttp: Fix for nil handlerErr.Err #4977

merged 1 commit into from
Aug 23, 2022

Conversation

francislavoie
Copy link
Member

Followup to #4971, need to check that there actually is a wrapped error before trying to grab its message.

Followup to #4971, need to check that there actually is a wrapped error before trying to grab its message.
@francislavoie francislavoie added the bug 🐞 Something isn't working label Aug 23, 2022
@francislavoie francislavoie added this to the v2.6.0-beta.1 milestone Aug 23, 2022
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Forgot that Err isn't always set. Thanks!

@mholt mholt merged commit a22c08a into master Aug 23, 2022
@mholt mholt deleted the handlererror-msg-fix branch August 23, 2022 14:17
@mholt mholt modified the milestones: v2.6.0-beta.1, v2.6.0 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants