Switch to program directory when running as Windows service #5115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all Windows services are run from the Windows system directory, make it easier for users by switching to our program directory right after the start.
TobiX
force-pushed
the
windows-service-workdir
branch
from
1f3b5e9
to
f4583b0
Compare
mholt
approved these changes
Oct 4, 2022
|
@mholt Unfortunately, there is nowhere to log TO when running as a windows service, since STDOUT & STDERR are discarded... IF somebody implements Windows event logging (https://pkg.go.dev/golang.org/x/sys/windows/svc/eventlog), that should become the default for Windows services, so errors can be logged... somewhere 😸 |
|
Good to know, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #5106, when installing Caddy as a native Windows service (For reference, the PowerShell command for that is
New-Service -Name caddy -BinaryPathName "C:\caddy\caddy.exe run"), caddy starts up inC:\WINDOWS\SYSTEM32- I think this is a bad idea for multiple reasons:Caddyfileintosystem32(well, you technically can, but that sound like a bad idea all around) and as an alternative, you have to run caddy with a much longer command line (LikeNew-Service -Name caddy -BinaryPathName "C:\caddy\caddy.exe run --config C:\caddy\Caddyfile"Caddyfile, those will be relative to thesystem32directory, which will lead to hard-to-debug problems...This is a "prototype" of a simple fix: When we are running as a Windows service, try to chdir into the caddy program directory - It works for me[tm] in a Windows 10 VM...