httpcaddyfile: Improve detection of indistinguishable TLS automation policies #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
added
in progress 🏃♂️
Seems like the reasonable thing to do if a plugin registers its own network type.
Add comments to try to explain what happened
|
Ok, I think this change is pretty good overall. It removes some unnecessary (and necessarily incorrect) checks, tweaks tests to hopefully improve their likelihood of passing (sigh, that race condition), updates a dependency (unrelated but accidentally snuck into this PR instead of a separate branch), and fixes HTTP/3 listening when the network type is unknown (because it may be specified by a plugin). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat experimental / WIP branch.
The problem is we have listener plugins that provide their own TLS, and we shouldn't be preventing a valid config from being produced. I think the assumptions made in this part of the code were too bold, and we need to relax them slightly now.
Initial change is a bit of a hack, but seems valid too. If
auto_https offis used, we don't even usehttpsHostsSharedWithHostlessKeyso we can skip the count which yields an error sometimes when it shouldn't.