fileserver: stop listing dir when request context is cancelled #5131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdusco
force-pushed
the
cancel-dir-listing
branch
3 times, most recently
from
b90f2aa
to
aa2c98c
Compare
Prevents caddy from performing disk IO needlessly when the request is cancelled before the listing is finished. Closes caddyserver#5129
abdusco
force-pushed
the
cancel-dir-listing
branch
from
aa2c98c
to
96cc4a2
Compare
francislavoie
added
under review 🧐
|
Thanks! This LGTM. Did this improve performance for you? |
|
@mholt it helped. Caddy now stops listing at the first chance it gets, check this out: #5129 (comment) |
mholt
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents caddy from performing disk IO needlessly when the request is cancelled before the listing is finished.
Closes #5129