Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fileserver: Implement caddyfile.Unmarshaler interface #5850

Merged
merged 3 commits into from
Jan 13, 2024
Merged

fileserver: Implement caddyfile.Unmarshaler interface #5850

merged 3 commits into from
Jan 13, 2024

Conversation

francislavoie
Copy link
Member

As pointed out by @dunglas, we were missing this to make it easier to embed file_server within other shortcut directives.

@francislavoie francislavoie added the feature ⚙️ New feature or request label Oct 2, 2023
mholt
mholt approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Still could be a footgun (like in reverse proxy) if programmers don't read the docs and forget to call Finalize... but overall I think this is reasonable. Thanks!

@mholt mholt modified the milestones: v2.7.5, 2.9.0 Oct 3, 2023
@francislavoie francislavoie modified the milestones: v2.9.0, v2.8.0 Jan 13, 2024
@francislavoie francislavoie enabled auto-merge (squash) January 13, 2024 21:27
@francislavoie francislavoie merged commit f3e849e into master Jan 13, 2024
25 checks passed
@francislavoie francislavoie deleted the fileserver-unmarshalcaddyfile branch January 13, 2024 21:32
@armadi1809 armadi1809 mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
feature ⚙️ New feature or request
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francislavoie @mholt