core: Add ctx.Slogger() which returns an slog logger
#5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislavoie
force-pushed
the
slog-interop
branch
from
0d169e5
to
504df3e
Compare
|
Oh this is good, thanks. Since we're going to bump up to Go 1.21 soon, do we want to remove the build tag and possibly even just put this into an existing file? |
|
Sure, can wait until we merge that (version bump) |
francislavoie
force-pushed
the
slog-interop
branch
from
504df3e
to
ff745bd
Compare
|
Okay, done @mholt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow modules that want to use
slogAPIs instead ofzapto do so easily. We take care of setting up the logger name using the module ID.This requires Go 1.21 so I put it in a separate file. Once we bump our minimum we can merge it back into
context.go.