caddyhttp: Register post-shutdown callbacks #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislavoie
force-pushed
the
stop-hooks
branch
from
7b55f27
to
c2e83a8
Compare
francislavoie
force-pushed
the
stop-hooks
branch
from
c2e83a8
to
890e27e
Compare
|
Ok, well, let's just merge this for now and we can change it later if needed. Thanks for the review Francis! |
|
ahh sorry this got lost in my inbox! haven't had a chance to test this, but it looks like it should do the trick! |
|
Ha no worries! Again if anything needs adjusting we can still do that 馃憤 |
mholt
added a commit
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the ability to register hooks to be invoked after the server has shut down. 馃帀
@jjiang-stripe