replacer: Fix escaped closing braces

[armadi1809]

Resolves #5993. Inside func (r *Replacer) replace we were returning the same input if it does not contain the opening brace but which meant that we were not treating the closing brace as a character that should be escaped.

[mohammed90]

Thank you for looking into the fix! Would you mind adding test cases? You can consider the reported config/behavior as one. If you can come up with more scenarios, that'd be great.

[armadi1809]

@mohammed90 I have a question. One of the tests that are currently present (And which I had to change to pass the checks) states that func (r *Replacer) ReplaceAll should return \} when the input is \}. Shouldn't it be } as the backslash is used to escape the brace and hence should be removed? Because a similar test exists with the opening brace and the backslash is indeed removed.

I am asking because I may be missing an intended behavior here. Thank you.

[mohammed90]

@mohammed90 I have a question. One of the tests that are currently present (And which I had to change to pass the checks) states that func (r *Replacer) ReplaceAll should return \} when the input is \}. Shouldn't it be } as the backslash is used to escape the brace and hence should be removed? Because a similar test exists with the opening brace and the backslash is indeed removed.

I am asking because I may be missing an intended behavior here. Thank you.

Checking git blame on that line shows it was added as part of PR #3121 to resolve #3116. I believe it's intended, but I'm not firm on this. I need to think about it, especially because that area of the code is not very familiar to me. Perhaps Francis or Matt can chime in.

[francislavoie]

Yeah looks weird to me, but also I don't think escaping was necessary at all in the reported issue.

I don't have any objections to this, collapsing escapes seems fine to me here (as long as \\} still works to output \} literally).

But yeah we should have some more test cases to make sure this change is bulletproof.

[armadi1809]

Thank you guys for the prompt responses. I will work on adding more test cases.

[armadi1809]

I just added a couple tests. Please let me know if you want to see more cases covered. Thank you!

[mohammed90]

Looking good, just a few minor nitpicks from my side.

[armadi1809]

@mohammed90 Thank you for taking the time to review! All your feedback points should now be addressed.

[francislavoie]

LGTM, thanks!

resolved

[mholt]

@armadi1809 Thank you for your contribution! Please feel welcome to contribute again :)