Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Inline Caddyfile syntax for ip_mask filter #6094

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

francislavoie
Copy link
Member

Just a small change to allow inlining the IP mask bits.

The config for IP masks is too verbose right now, especially because we log the IP in multiple fields: request>remote_ip, request>client_ip, and possibly in request headers depending on the clients/proxies.

Before:

			request>remote_ip ip_mask {
				ipv4 16
				ipv6 32
			}
			request>client_ip ip_mask {
				ipv4 16
				ipv6 32
			}

After:

			request>remote_ip ip_mask 16 32
			request>client_ip ip_mask 16 32

@francislavoie francislavoie added the feature ⚙️ New feature or request label Feb 11, 2024
@francislavoie francislavoie added this to the v2.8.0 milestone Feb 11, 2024
@francislavoie francislavoie enabled auto-merge (squash) February 12, 2024 17:10
@francislavoie francislavoie merged commit 91ec754 into master Feb 12, 2024
24 of 25 checks passed
@francislavoie francislavoie deleted the ip-mask-inline branch February 12, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants