fileserver: Preserve query during canonicalization redirect #6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Mar 5, 2024
|
Yeah we only ever use it with the path currently, so it's fine. I'll add a comment. |
francislavoie
force-pushed
the
canon-preserve-query
branch
from
879bef4
to
255d820
Compare
francislavoie
force-pushed
the
canon-preserve-query
branch
from
4fc13fe
to
6fefab4
Compare
mholt
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #5254
Context: https://caddy.community/t/caddy-stripping-querystring/22754
When a canonicalization redirect happens, it's only taking the path and adding a
/, which loses the original query if there was one.This preserves it safely, without making additional modifications to the URL.