New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use context.WithoutCancel instead of ignoreClientGoneContext #6116

Merged

mholt merged 1 commit into master from remove-ignore-cancel-context

Feb 20, 2024

Member

WeidiDeng commented Feb 20, 2024

Now that the minimal version of go is 1.21, we can safely use context.WithoutCancel.


          use context.WithoutCancel instead of ignoreClientGoneContext

9e04b6e

WeidiDeng requested review from francislavoie and mholt

February 20, 2024 03:07

mholt approved these changes

View reviewed changes

Member

mholt left a comment

Yay! Thank you Weidi.

mholt merged commit 53f7035 into master

25 checks passed

mholt deleted the remove-ignore-cancel-context branch

February 20, 2024 03:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment