Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caddyfile: Add support for the dynamic srv's grace_period option #6264

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Caddyfile: Add support for the dynamic srv's grace_period option #6264

merged 1 commit into from
Apr 23, 2024

Conversation

armadi1809
Copy link
Contributor

Closes #6261

@armadi1809
Copy link
Contributor Author

The linting error is coming from here

mholt
mholt requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this -- can we just update the godoc comment at the top of UnmarshalCaddyfile to include the grace_period doc?

@armadi1809 armadi1809 force-pushed the dynamic-srv-caddyfile-grace-period branch from b8242ec to 4180479 Compare April 23, 2024 01:17
@armadi1809 armadi1809 force-pushed the dynamic-srv-caddyfile-grace-period branch from 4180479 to eb3cdb4 Compare April 23, 2024 01:20
@armadi1809
Copy link
Contributor Author

armadi1809 commented Apr 23, 2024 •
edited

@mholt Just updated the godoc comment. Thanks for reviewing.

mholt
mholt approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. thank you!

@mholt mholt merged commit 868af6a into caddyserver:master Apr 23, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie left review comments

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Caddyfile wiring for proxy dynamic srv's grace_period option
3 participants
@armadi1809 @mholt @francislavoie