Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 63+ character requests #130

Closed
ColinChartier opened this issue May 22, 2021 · 3 comments
Closed

Support 63+ character requests #130

ColinChartier opened this issue May 22, 2021 · 3 comments
Labels
feature request Request for new feature or functionality

Comments

@ColinChartier
Copy link

ColinChartier commented May 22, 2021

What would you like to have changed?

We use certmagic to generate certificates of the form (branch name).demo.example.com for ephemeral environments, but the branch name can sometimes be long enough that the domain is >63 characters
It'd be great if we could include two SANs, where the common name is just demo.example.com (or whatever) and the second SAN is the whole (branch name).demo.example.com to circumvent the 63 character common name restriction.

Why is this feature a useful, necessary, and/or important addition to this project?

It wouldn't necessarily have to be a very big change, just adding a fixed "base domain" to the config object to always be the common name, and would avoid problems like "NewOrder request did not include a SAN short enough to fit in CN"

What alternatives are there, or what are you doing in the meantime to work around the lack of this feature?

N/A

Please link to any relevant issues, pull requests, or other discussions.

N/A

@ColinChartier ColinChartier added the feature request Request for new feature or functionality label May 22, 2021
@ColinChartier ColinChartier changed the title Support 63+ character subdomains Support 63+ character requests May 22, 2021
ColinChartier pushed a commit to ColinChartier/certmagic that referenced this issue May 22, 2021
@ColinChartier
Copy link
Author

Example domain that doesn't currently work: https://www.adding-new-fields-pt-2-1978653611.testing.demo.example.com/

@ColinChartier
Copy link
Author

ColinChartier@1e641de sort of works, but the certificate isn't served (I think because the cache uses ",'.join(sans) right now)

@mholt
Copy link
Member

mholt commented May 24, 2021

CertMagic does not set CommonName, so this is not a CertMagic problem.

@mholt mholt closed this as completed May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for new feature or functionality
Projects
None yet
Development

No branches or pull requests

2 participants