Fix a panic when attempting to log when certificate should not be renewed #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v0.17.1, we're seeing the following panic occur (and subsequently, no recovery) over at sish.
This occurs because we don't use zap for logging, which leads to
loggerNamed
returningnil
. I went through and checked all other logger references and made sure they are guarded by the same issue by checking thatlog
is notnil
.