Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the default cache logger to be set #213

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Allow the default cache logger to be set #213

merged 1 commit into from
Jan 10, 2023

Conversation

pwilloughby
Copy link
Contributor

No description provided.

mholt
mholt approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is probably sensible. Have you noticed this benefit you? How?

@pwilloughby
Copy link
Contributor Author

Have you noticed this benefit you? How?

This benefits me because it allows changing the cache logger when using the high-level convenience functions HTTPS(), Listen(), TLS(). I think the only way to set the cache logger currently is to make your own cache.

@mholt mholt merged commit 91cbe17 into caddyserver:master Jan 10, 2023
@mholt
Copy link
Member

mholt commented Jan 10, 2023

Yeah, that's true. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pwilloughby @mholt