Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass custom dialer to http.Transport #37

Closed
sergeyfrolov opened this issue Jul 2, 2018 · 0 comments
Closed

Pass custom dialer to http.Transport #37

sergeyfrolov opened this issue Jul 2, 2018 · 0 comments

Comments

@sergeyfrolov
Copy link
Member

Recently we implemented long-requested access control lists feature #11, and added manual dialing in order to control that attacker could not get access to forbidden destinations with sneaky redirects in http responses.
Unfortunately, for all those nasty over-9000-http-requests workloads, we now establish separate tcp connection for each request. Establishing tcp connection to get favicon and then close is no bueno performance-wise.
We can solve this by passing a custom dialer(with built-in ACL) to http.Transport and letting HTTP package do socket pooling and reuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant