Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade caddy to v2.6.4 #104

Merged
merged 1 commit into from
Jun 2, 2023
Merged

chore: Upgrade caddy to v2.6.4 #104

merged 1 commit into from
Jun 2, 2023

Conversation

Embraser01
Copy link
Member

No description provided.

@francislavoie
Copy link
Member

We're at v2.6.4 now. Maybe this should get updated and bumped

@Embraser01 Embraser01 changed the title chore: Upgrade caddy to v2.5.2 chore: Upgrade caddy to v2.6.4 Mar 19, 2023
@Embraser01
Copy link
Member Author

Just tried to upgrade to latest version of caddy and stumbled on an issue due to glog.
We have a deep dep that define the v flag and cause a panic when we defined our own v flag.

# go mod why gives this:
# github.com/golang/glog
github.com/caddyserver/ingress/internal/caddy/global
github.com/caddyserver/caddy/v2/modules/caddytls
github.com/caddyserver/caddy/v2/modules/caddypki
github.com/smallstep/certificates/authority
github.com/smallstep/nosql
github.com/smallstep/nosql/badger/v1
github.com/dgraph-io/badger
github.com/dgraph-io/ristretto/z
github.com/golang/glog

I'll just rename the flag for now (those using helm will not have to change anything, others may have to change. Because it's not something that should be enabled in a "production" env, I don't think it's a big issue).

@Embraser01 Embraser01 marked this pull request as ready for review March 19, 2023 21:32
@Embraser01 Embraser01 merged commit c2b28c4 into master Jun 2, 2023
@Embraser01 Embraser01 deleted the embraser01/up-caddy branch June 2, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants