Added LoadBalancer annotations and LoadBalancerIP #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinbinhuang
reviewed
Oct 26, 2022
Embraser01
previously approved these changes
Dec 6, 2022
Embraser01
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for both issue #110 and #109
I left some of the more common annotations required for an AWS NLB as comments. It's not as good as instructions, but it should help some people who have no idea what to put in that section.
I updated my project with this template and these additions to the values.yaml. Everything appears to be functioning as it should (the LoadbBalancerIP section is blank for me because I'm linking AWS EIPs).