Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor formatting improvements #146

Merged
merged 1 commit into from
Oct 16, 2023
Merged

chore: minor formatting improvements #146

merged 1 commit into from
Oct 16, 2023

Conversation

mavimo
Copy link
Member

@mavimo mavimo commented Oct 7, 2023 •
edited

Changes

  • Minor changes in formatting (automated)

@mavimo mavimo self-assigned this Oct 7, 2023
Embraser01
Embraser01 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Embraser01 Embraser01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Is there a way to have this formatting checked during CI?

@mavimo
Copy link
Member Author

mavimo commented Oct 16, 2023 •
edited

I will like to enforce with golang-ci, but not sure on adding it here (I'm try to fix the minor issue in different PRs and once we are "cose enough" we will bring it in, otherwise we will have large changes coming in the same PR 😓 )
WDYT?

@mavimo mavimo merged commit 855d5d8 into master Oct 16, 2023
2 checks passed
@mavimo mavimo deleted the monor-formatting-fixes branch October 16, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Embraser01 Embraser01 Embraser01 approved these changes

Assignees

@mavimo mavimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mavimo @Embraser01