Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for pkg/store #147

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add tests for pkg/store #147

merged 1 commit into from
Oct 16, 2023

Conversation

mavimo
Copy link
Member

@mavimo mavimo commented Oct 8, 2023

Changes

  • Add test to pkg/store

NB: to be merged after #142

@mavimo mavimo self-assigned this Oct 8, 2023
@mavimo mavimo changed the base branch from master to AaronDewes-update-caddy-2.7.3 October 8, 2023 09:33
@mavimo mavimo marked this pull request as draft October 8, 2023 16:11
Base automatically changed from AaronDewes-update-caddy-2.7.3 to master October 16, 2023 09:20
@Embraser01 Embraser01 marked this pull request as ready for review October 16, 2023 11:12
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d7ffeb6) 32.42% compared to head (cfaddd2) 37.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   32.42%   37.08%   +4.66%     
==========================================
  Files          10       12       +2     
  Lines         293      364      +71     
==========================================
+ Hits           95      135      +40     
- Misses        197      228      +31     
  Partials        1        1              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Embraser01 Embraser01 merged commit 03dbd7d into master Oct 16, 2023
4 checks passed
@Embraser01 Embraser01 deleted the add-tests branch October 16, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants