Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Attempt to clarify how handle directives may be re-ordered #264

Merged
merged 1 commit into from Sep 14, 2022

Conversation

asb
Copy link
Contributor

@asb asb commented Sep 14, 2022

As discussed in caddyserver/caddy#5037.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a nice improvement. What do you think about my suggestion?

src/docs/markdown/caddyfile/directives/handle.md Outdated Show resolved Hide resolved
@asb asb force-pushed the handle-directive-reordering branch from 18eb9c5 to 4af3780 Compare September 14, 2022 04:02
@mholt mholt merged commit a87295b into caddyserver:master Sep 14, 2022
@francislavoie
Copy link
Member

It's not actually only if there's a single path matcher iirc, doesn't it still apply to named matchers with multiple paths too?

@mholt
Copy link
Member

mholt commented Sep 14, 2022

@francislavoie With my recent patch, it now applies only to any form of matcher as long as it has just 1 path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants