Skip to content

Commit

Permalink
feat(opentelemetry): Do not capture exceptions for timed events (gets…
Browse files Browse the repository at this point in the history
  • Loading branch information
lforst authored and cadesalaberry committed Apr 19, 2024
1 parent 726d21e commit 87ed280
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 249 deletions.
2 changes: 0 additions & 2 deletions packages/opentelemetry/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { maybeCaptureExceptionForTimedEvent } from './utils/captureExceptionForTimedEvent';
import { getRequestSpanData } from './utils/getRequestSpanData';

export type { OpenTelemetryClient } from './types';
Expand Down Expand Up @@ -47,7 +46,6 @@ export { getClient } from '@sentry/core';
* @hidden
*/
const _INTERNAL = {
maybeCaptureExceptionForTimedEvent,
getRequestSpanData,
} as const;

Expand Down
6 changes: 0 additions & 6 deletions packages/opentelemetry/src/spanProcessor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { logger } from '@sentry/utils';
import { DEBUG_BUILD } from './debug-build';
import { SEMANTIC_ATTRIBUTE_SENTRY_PARENT_IS_REMOTE } from './semanticAttributes';
import { SentrySpanExporter } from './spanExporter';
import { maybeCaptureExceptionForTimedEvent } from './utils/captureExceptionForTimedEvent';
import { getScopesFromContext } from './utils/contextData';
import { setIsSetup } from './utils/setupCheck';
import { setSpanScopes } from './utils/spanData';
Expand Down Expand Up @@ -48,11 +47,6 @@ function onSpanStart(span: Span, parentContext: Context): void {
}

function onSpanEnd(span: Span): void {
// Capture exceptions as events
span.events.forEach(event => {
maybeCaptureExceptionForTimedEvent(event, span);
});

const client = getClient();
client?.emit('spanEnd', span);
}
Expand Down
55 changes: 0 additions & 55 deletions packages/opentelemetry/src/utils/captureExceptionForTimedEvent.ts

This file was deleted.

55 changes: 0 additions & 55 deletions packages/opentelemetry/test/integration/otelTimedEvents.test.ts

This file was deleted.

This file was deleted.

0 comments on commit 87ed280

Please sign in to comment.