Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy honeycomb structure shifted in lattice by v2decoder #105

Closed
cmaffeo opened this issue Mar 27, 2017 · 1 comment
Closed

Legacy honeycomb structure shifted in lattice by v2decoder #105

cmaffeo opened this issue Mar 27, 2017 · 1 comment

Comments

@cmaffeo
Copy link

cmaffeo commented Mar 27, 2017

Problem

The helices in the legacy json file get placed in the wrong row by the cadnano2.5 v2decoder (see images below). I'm not sure about other design files.

cadnano2

screen shot 2017-03-27 at 11 57 42 am

cadnano2.5

screen shot 2017-03-27 at 12 01 13 pm

Possible fix

Inserting 'delta_row += 1' after line 68 in cadnano/fileio/v2decode.py fixed the issue for this structure, but this might not be general.

@cmaffeo
Copy link
Author

cmaffeo commented Mar 28, 2017

The fix suggested above is no good because it flips the assignment of fwd/rev strands, which was correct for my test cases.

As a possible alternative, I've uploaded a patch that swaps the conditional in the legacyLatticeCoordToPositionXY method in lattice.py and conditionally shift the row index for honeycomb structures in v2decoder.py.

The patch works for a couple of json files I have laying around and for the files in the cadnano/tests/data directory, but it might affect the c25decoder. Also the blue grid in the background can become shifted so it lies outside the red box in the left panel of cadnano, which probably needs to be fixed.

sdouglas added a commit that referenced this issue Apr 28, 2017
Thanks @cmaffeo for documenting & suggesting a patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants