Created new constructor in MockSerializationResult and implemented getStatus in MockHttpServletResponse #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 8, 2013 15:42
| @@ -75,6 +75,11 @@ public MockSerializationResult() { | |||
| this(new JavassistProxifier(new ObjenesisInstanceCreator()), new NullProxyInitializer()); | |||
| } | |||
|
|
|||
| public MockSerializationResult(MockHttpServletResponse response) { | |||
There was a problem hiding this comment.
Any reason to use MockHttpServletResponse instead of HttpServletResponse?
There was a problem hiding this comment.
Yes. because MockSerializationResult uses MockHttpServletResponse internal methods that don't come from the inferface (HttpServletResponse), like that:
public String serializedResult() throws Exception {
if("application/xml".equals(response.getContentType())){
return response.getContentAsString();
}
if("application/json".equals(response.getContentType())){
return response.getContentAsString();
}
return null;
}
lucascs
added a commit
that referenced
this pull request
Jul 9, 2013
Created new constructor in MockSerializationResult and implemented getStatus in MockHttpServletResponse
|
Thanks! |
garcia-jj
added a commit
to caelum/vraptor4
that referenced
this pull request
Sep 13, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you're using MockSerializationResult and you have to change response status code, you can't test it, because MockSerializationResult already instantiates MockHttpServletResponse.