allowing controllers to receive optional parameters

[nykolaslima]

Currently we can't create a controller method that receives an optional parameter, when using deserialization.

@Post("/doSomething")
@Consumes("application/json")
public void doSomething(Car car) {
}

If we call /doSomething with empty body, this will throw a NullPointerException because it does not have Content-Type header.

POST /doSomething (works great!)
{
  car: {
    ....
  }
}

POST /doSomething (throws a NullPointerException)
<<no body>>

[garcia-jj]

I'd use warn.

[nykolaslima]

Thanks for you comment @garcia-jj. Done!

We need to replicate this to VRaptor4?

[Turini]

can you reproduce it on vr4? If so, it would be nice to replicate the solution

[garcia-jj]

I can't understand why this solution allow optional parameters, because we
only check if content type is null.

Why content type is related to parameters? Why you simple bypass
deserialization?

Your pull request sounds good, but I did this questions because I don't
understand the scenario.

[garcia-jj]

+1 to replicate to vraptor 4.

[nykolaslima]

When you make a request without content, then it wont have the Content-Type
header and it causes a NullPointerException. @garcia-jj

On Tuesday, October 14, 2014, Otávio Garcia notifications@github.com
wrote:

+1 to replicate to vraptor 4.

—
Reply to this email directly or view it on GitHub
#618 (comment).

[garcia-jj]

Hmm, ok, now I see your point. Sounds like good to merge for me. Can you send a pull request in vr4 linked to this pull request?

Thank you

[nykolaslima]

Sure!

I'll do this. But this interceptor does not exists in VRaptor4. I'll find out where this logic has been doing there.

Thank you.

[Turini]

DeserializingObserver at VRaptor 4

[nykolaslima]

Thanks Turini, I'll send a pullrequest right now.

[]s

2014-10-14 11:19 GMT-03:00 Rodrigo Turini notifications@github.com:

DeserializingObserver at VRaptor 4

—
Reply to this email directly or view it on GitHub
#618 (comment).

[nykolaslima]

@Turini we already merged the VRaptor4 implementation. Can we merge this now?

[Turini]

done! thank you again, @nykolaslima

[nykolaslima]

No problem. Thank you.

2014-10-14 18:00 GMT-03:00 Rodrigo Turini notifications@github.com:

done! thank you again, @nykolaslima https://github.com/nykolaslima

—
Reply to this email directly or view it on GitHub
#618 (comment).