Fixing #734 that causes a StackOverflow when we use Result.redirectTo #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garcia-jj
added a commit
that referenced
this pull request
Sep 7, 2014
Fixing #734 that causes a StackOverflow when we use Result.redirectTo
|
Nice! On Sunday, September 7, 2014, Otávio Garcia notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #734 pull request that causes a
StackOverflowErrorwhen I use aResult.redirectTo(Object)in my application. The #734 pull request forgot to add a cast toClass<T>to callResult.redirectTo(Class<T>). So the method call himself infinitely throwing aStackOverflowError.I'll merge this pull request because can break some apps. I have tested in my application right now and everything works fine. And if any problems occurs we can fix (I think won't), we can rollback.