Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPD7in5 support #33

Merged
merged 3 commits into from
Nov 21, 2019
Merged

EPD7in5 support #33

merged 3 commits into from
Nov 21, 2019

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Nov 16, 2019

No description provided.

@str4d
Copy link
Contributor Author

str4d commented Nov 16, 2019

This seems to be about twice as slow to write to the screen as the Waveshare Python controller (specifically the July 10 2017 version, which is what I currently have hooked up to my screen), despite using the same panel settings.

@codecov-io
Copy link

codecov-io commented Nov 16, 2019

Codecov Report

Merging #33 into master will increase coverage by 11.62%.
The diff coverage is 45.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #33       +/-   ##
===========================================
+ Coverage   29.64%   41.26%   +11.62%     
===========================================
  Files           8       15        +7     
  Lines         533      853      +320     
===========================================
+ Hits          158      352      +194     
- Misses        375      501      +126
Impacted Files Coverage Δ
src/epd7in5/command.rs 100% <100%> (ø)
src/epd7in5/graphics.rs 100% <100%> (ø)
src/epd7in5/mod.rs 4.59% <4.59%> (ø)
src/traits.rs 0% <0%> (ø)
src/interface.rs 0% <0%> (ø)
src/color.rs 84.84% <0%> (ø)
src/graphics.rs 95.14% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9390f9a...3bd62b3. Read the comment docs.

@str4d
Copy link
Contributor Author

str4d commented Nov 16, 2019

Measuring some drawing times (DATA_START_TRANSMISSION_1 + DISPLAY_REFRESH):

  • Old Python driver: 24s
    • Buffer is 30720 bytes (= HEIGHT * WIDTH / 8)
    • Writes 4 data bytes per buffer byte
  • Latest Python driver: 30s
    • Buffer is HEIGHT * WIDTH / 4 bytes
    • Writes 2 data bytes per buffer byte
  • This Rust driver: 53s
    • Buffer is HEIGHT * WIDTH / 8 bytes
    • Writes 4 data bytes per buffer byte

Copy link
Owner

@caemor caemor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Could you add the 7in5 display to the readme as well?

@caemor
Copy link
Owner

caemor commented Nov 19, 2019

Measuring some drawing times (DATA_START_TRANSMISSION_1 + DISPLAY_REFRESH):

* Old Python driver: 24s
  
  * Buffer is 30720 bytes (`= HEIGHT * WIDTH / 8`)
  * Writes 4 data bytes per buffer byte

* Latest Python driver: 30s
  
  * Buffer is `HEIGHT * WIDTH / 4` bytes
  * Writes 2 data bytes per buffer byte

* This Rust driver: 53s
  
  * Buffer is `HEIGHT * WIDTH / 8` bytes
  * Writes 4 data bytes per buffer byte

You are using one of the raspberry pis?
Can you give me a link to the specific version you were using? I don't know why we are so much slower besides maybe doing some additional checks, but that shouldn't slow us down so much 🤔

@str4d
Copy link
Contributor Author

str4d commented Nov 20, 2019

Added to the readme.

Can you give me a link to the specific version you were using?

I'm using the Raspberry Pi Zero W.

@caemor
Copy link
Owner

caemor commented Nov 20, 2019

Added a new issue for the performance tracking

@caemor caemor merged commit 6520bbf into caemor:master Nov 21, 2019
@caemor
Copy link
Owner

caemor commented Mar 27, 2020

@str4d do you remember if you used the same spi-frequency?

@str4d str4d deleted the epd7in5 branch December 5, 2020 23:04
@str4d str4d restored the epd7in5 branch December 6, 2020 00:41
@str4d str4d deleted the epd7in5 branch December 6, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants