Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 1% overlap steps. #11

Closed
Weissrolf opened this issue Aug 24, 2022 · 5 comments
Closed

Allow 1% overlap steps. #11

Weissrolf opened this issue Aug 24, 2022 · 5 comments

Comments

@Weissrolf
Copy link

Hi.

I am trying to make walled-templates auto-target in Pathfinder 5/10/5 (movement) style by using the "Overlap method". Unfortunately 80% works for circle and one orientation of cone, but not for the other type of cone. And 70% works both both types of cones, but not for circles. So maybe I could find some in between coverage (71-79%) that might work for both, but currently only steps of 10 are allowed.

@Weissrolf
Copy link
Author

Weissrolf commented Aug 25, 2022

I modified a bit and made Walled Templates use an overlap value of 0.75. This works in a 5E world:

Unfortunately in my PF2 world there is something not working properly with overlap mode:

The right outer side of the circle does not work in overlap mode even at a value of 0.

@Weissrolf
Copy link
Author

I tried the same in an empty PF2 world and there it works properly. So I will have to find out what breaks functionality in my existing PF2 world.

But the gist of it is that overlap values between 0.7 and 0.8 work, so it would be nice if you could change the current settings limitation from 0.1 to 0.01.

@Weissrolf
Copy link
Author

I seem to have fixed my broken world where walled templates deformed (and there also is a conflict with a the PF2 TokenMagic Integration module that I disable for the time being).

Setting an overlap value of 0.75 seems to give me the templates I need now, so coming back to my original feature request: please allow value changes of 0.01 in the settings. :)

caewok added a commit that referenced this issue Sep 3, 2022
@caewok
Copy link
Owner

caewok commented Sep 3, 2022

Okay, if I did it right, both v9 (version 0.3.5) and v10 (version 0.4.1) versions should now allow step increment in 0.01.

PF2 TokenMagic Integration definitely interferes with walled templates; see my comment on your other issue.

Circles are hard because of some weirdness about exactly where the circle perimeter lies. So it would not surprise me if they are still occasionally screwed up. Feel free to submit a new issue if you see more weirdness.

@caewok caewok closed this as completed Sep 3, 2022
@Weissrolf
Copy link
Author

Great, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants