Changed TestableAggregateRoot to be explicit on commandhandling failures #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensured TestableAggregateRoot works properly based on a starting 'given' (the actor was created in when, that is now part of given that is actually class constructor work) Added tests to cover the functionality of TestableAggregateRoot
wketting
approved these changes
Aug 30, 2018
| @@ -6,6 +6,8 @@ package io.cafienne.bounded.test | |||
|
|
|||
| import java.util.concurrent.atomic.AtomicInteger | |||
|
|
|||
| import io.cafienne.bounded.test.TestableAggregateRoot.{CommandHandlingException, IllegalCommandException} | |||
|
|
|||
| import scala.reflect.ClassTag | |||
| //import scala.reflect.runtime.universe | |||
| import io.cafienne.bounded.test.TestAggregateRoot.TestAggregateRootState | ||
| import scala.collection.immutable.Seq | ||
|
|
||
| //object DomainProtocol { |
| import io.cafienne.bounded.{BuildInfo, RuntimeInfo} | ||
| import io.cafienne.bounded.aggregate.{AggregateRootId, CommandMetaData, MetaData} | ||
| import io.cafienne.bounded.test.TestableAggregateRoot.{CommandHandlingException, IllegalCommandException} | ||
| //import io.cafienne.bounded.test.DomainProtocol.InitialStateCreated |
|
Updated code to remove the issues around the comments. Commented code is removed and/or enabled. Thanks. Will merge this when all is fine. (and publish a new version) |
|
@olger You can merge this PR, and publish a new version. Don't forget to update the release notes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensured TestableAggregateRoot works properly based on a starting 'given' (the actor was created in when, that is now part of given that is actually class constructor work)
Added tests to cover the functionality of TestableAggregateRoot