Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing a case file item array with an empty array crashes the engine #428

Closed
tpetter opened this issue Apr 3, 2024 · 0 comments · Fixed by #429
Closed

Replacing a case file item array with an empty array crashes the engine #428

tpetter opened this issue Apr 3, 2024 · 0 comments · Fixed by #429

Comments

@tpetter
Copy link
Member

tpetter commented Apr 3, 2024

The optimization logic in the casefile projection is putting the CaseFileItemChildRemoved event at the last, and the optimization algorithm in the CaseFileEventBuffer does not take that into account properly.
Better to remove the optimization logic?
tpetter added a commit to cafienne/cmmn-test-framework that referenced this issue Apr 3, 2024
@tpetter
Add test to reproduce engine #428
4fbcbac 
See cafienne/cafienne-engine#428
tpetter added a commit that referenced this issue Apr 4, 2024
@tpetter
Fix optimization in CaseFileProjection
04a1cff 
Fixes #428

Take correct path from CaseFileItemChildRemoved, and use that for updating the event list.

Also bit of refactoring to leave the merging of events to the CaseFileEventBuffer itself
This was referenced Apr 4, 2024
Merged
Merged
@olger olger closed this as completed in #429 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix optimization in CaseFileProjection cafienne/cafienne-engine
1 participant
@tpetter