refactor(main): Use nested routing #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than repeating the route prefixes, use nested routing. This does require splitting out the Codeberg redirect from the rest of the Forgejo routes, but that's not necessarily a bad thing. Signed-off-by: Gergely Nagy <me@gergo.csillger.hu>
Add a `/v1/gitea` route, handled by the same code as `/v1/forgejo`. Signed-off-by: Gergely Nagy <me@gergo.csillger.hu>
|
Rebased on main & force pushed |
cafkafk
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than repeating the route prefixes, use nested routing. This does require splitting out the Codeberg redirect from the rest of the Forgejo routes, but that's not necessarily a bad thing. (Implemented in be9eb85)
The topmost commit (42548aa) adds a
/v1/gitearoute, handled by the same code as/v1/forgejo, without a redirect.Builds on top of #2.