Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for bike power functions #2174

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Commits on Mar 1, 2024

  1. Configuration menu
    Copy the full SHA
    678facc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15d2753 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    bf4bf1e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c74fe53 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    6fc5022 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    d9c9f29 View commit details
    Browse the repository at this point in the history
  2. cagnulein#2174 added minmax type and introduced minimum and maximum r…

    …esistance for bikes. Move some power-related functionality up the class heirarchy
    drmason789 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e335ac2 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Configuration menu
    Copy the full SHA
    2ab31e8 View commit details
    Browse the repository at this point in the history
  2. cagnulein#2174 added bike cadence limits.

    - Disabled test for going below minimum cadence as there's no public way of setting a negative cadence.
    - Boundary tests mostly if not all passing.
    - Tests that resistanceFromPowerRequest inverts powerFromResistanceRequest still failing
    drmason789 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6d76f98 View commit details
    Browse the repository at this point in the history
  3. cagnulein#2174

    - adjusted power conversion test to force no watt gain
    - adjusted bike::resistanceFromPowerRequest to make it easier to see what it's comparing and to cache calculations
    - many power conversion tests now passing, but some strange values remain in the failing tests
    drmason789 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    26d2aac View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. cagnulein#2174

    - fixed test settings / watt gain
    - adjusted some wattsFromResistance functions to avoid test timeouts
    - temporarily use subset of resistance values for power conversion test to avoid timeouts
    drmason789 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    439570b View commit details
    Browse the repository at this point in the history
  2. cagnulein#2174 removed typo

    drmason789 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d2be67c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ce54799 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6e018a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. cagnulein#2174 increase use of minmax<T> in test code. Some work to m…

    …ake Peloton conversions invert.
    drmason789 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    55cb801 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    30dfa77 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Configuration menu
    Copy the full SHA
    a561444 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ca3644 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    da9ebd8 View commit details
    Browse the repository at this point in the history