Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move component CSS inserts into custom elements #915

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

xjensen
Copy link
Collaborator

@xjensen xjensen commented Jul 29, 2022

Addresses #914 by moving CSS insertion into each custom element's constructor. This removes the const style from global scope in each file, which may assist in some multi-component build scenarios.

Affected components include the following.

  • accordion
  • back-to-top
  • combined-css
  • page-alert
  • page-feedback
  • page-navigation
  • pagination

@github-actions
Copy link

Preview site available at 914-less-const.pr.designsystem.webstandards.ca.gov.

@xjensen xjensen requested review from a team, aaronhans and zakiya July 29, 2022 22:44
Copy link
Contributor

@aaronhans aaronhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, cleaner now

@zakiya
Copy link
Collaborator

zakiya commented Aug 1, 2022

@xjensen have these changes been pushed to npm?

(Something to think about for the whole team: Can we have a way of knowing/ensuring packages are updated on npm without asking on an individual basis?)

@xjensen
Copy link
Collaborator Author

xjensen commented Aug 1, 2022

@zakiya No, not yet pushed to NPM. I could push beta versions if needed.

Also, do you want me to merge this into the release branch now, or toward the end of the sprint?

(Ideally we could come up with a script that would do all the publishing to NPM based on changed version numbers, so nobody would need to go through each component.)

@zakiya
Copy link
Collaborator

zakiya commented Aug 1, 2022

Merge now please.

Sprint ends at the end of the quarter (September) so let's publish to npm now so changes can be available to Danny.

(🤔 )

@xjensen xjensen merged commit d6b3c92 into release/1.0.10-fremont-peak Aug 1, 2022
@xjensen
Copy link
Collaborator Author

xjensen commented Aug 1, 2022

Merged and published to NPM.

@xjensen xjensen deleted the 914-less-const branch August 1, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants