Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tetris from NetBSD #1024

Merged
merged 98 commits into from Mar 25, 2021
Merged

Port tetris from NetBSD #1024

merged 98 commits into from Mar 25, 2021

Conversation

j-piecuch
Copy link
Collaborator

@j-piecuch j-piecuch commented Feb 27, 2021

tetris/input.c needed to be modified so that it doesn't use poll().

They implement a really simple key-value database.
libterminfo stores terminal capabilities in this type of database.
@j-piecuch j-piecuch added the WiP not ready for code review label Feb 27, 2021
@j-piecuch j-piecuch added review please review this PR and removed WiP not ready for code review labels Mar 14, 2021
bin/tetris/input.c Outdated Show resolved Hide resolved
@j-piecuch j-piecuch requested a review from wiklam March 15, 2021 11:57
Copy link
Collaborator

@wiklam wiklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, review focused on file bin/tetris/input.c.

@j-piecuch j-piecuch added accepted accepted by the maintainer for code review and removed review please review this PR labels Mar 16, 2021
@cahirwpz cahirwpz merged commit 922718a into cahirwpz:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted accepted by the maintainer for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants