Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(owner): add owner #23

Merged
merged 1 commit into from Oct 16, 2018
Merged

chore(owner): add owner #23

merged 1 commit into from Oct 16, 2018

Conversation

whalecold
Copy link
Member

What this PR does / why we need it:

chore(owner): add owner

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @li-ang

Release note:

NONE

@whalecold whalecold requested a review from zoumo as a code owner October 16, 2018 07:18
@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2018
@whalecold
Copy link
Member Author

/cherrypick release-0.3

@caicloud-bot
Copy link
Contributor

@whalecold: once the present PR merges, I will cherry-pick it on top of release-0.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

li-ang
li-ang reviewed Oct 16, 2018
View reviewed changes
Copy link
Contributor

@li-ang li-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2018
@caicloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: li-ang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@caicloud-bot caicloud-bot merged commit 6a83bde into caicloud:master Oct 16, 2018
@caicloud-bot
Copy link
Contributor

@whalecold: #23 failed to apply on top of branch "release-0.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	OWNERS
Falling back to patching base and 3-way merge...
Auto-merging OWNERS
CONFLICT (content): Merge conflict in OWNERS
Patch failed at 0001 chore(owner): add owner

In response to this:

/cherrypick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@whalecold
Copy link
Member Author

/cherrypick release-0.3

@caicloud-bot
Copy link
Contributor

@whalecold: #23 failed to apply on top of branch "release-0.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	OWNERS
Falling back to patching base and 3-way merge...
Auto-merging OWNERS
CONFLICT (content): Merge conflict in OWNERS
Patch failed at 0001 chore(owner): add owner

In response to this:

/cherrypick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@li-ang
Copy link
Contributor

li-ang commented Oct 18, 2018

/cherrypick release-0.3

@caicloud-bot
Copy link
Contributor

@li-ang: #23 failed to apply on top of branch "release-0.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	OWNERS
Falling back to patching base and 3-way merge...
Auto-merging OWNERS
CONFLICT (content): Merge conflict in OWNERS
Patch failed at 0001 chore(owner): add owner

In response to this:

/cherrypick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@li-ang
Copy link
Contributor

li-ang commented Oct 18, 2018

/cherrypick release-0.3

@caicloud-bot caicloud-bot mentioned this pull request Oct 18, 2018
Merged
@caicloud-bot
Copy link
Contributor

@li-ang: new pull request created: #25

In response to this:

/cherrypick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-ang li-ang li-ang left review comments

@zoumo zoumo Awaiting requested review from zoumo

Assignees

@li-ang li-ang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@whalecold @caicloud-bot @li-ang