Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic error when abort the pipeline #330

Closed
supereagle opened this issue Jan 25, 2018 · 0 comments
Closed

Panic error when abort the pipeline #330

supereagle opened this issue Jan 25, 2018 · 0 comments

Comments

@supereagle
Copy link
Member

What happened
Abort the pipeline which has no log, there will be panic error:

unknown error: [restful] recover from panic situation: - runtime error: slice bounds out of range /usr/local/go/src/runtime/asm_amd64.s:509 /usr/local/go/src/runtime/panic.go:491 /usr/local/go/src/runtime/panic.go:35 /go/src/github.com/caicloud/cyclone/pkg/event/event.go:138 /go/src/github.com/caicloud/cyclone/pkg/event/event.go:120 /go/src/github.com/caicloud/cyclone/pkg/event/manager.go:188 /go/src/github.com/caicloud/cyclone/pkg/server/router/pipelineRecord.go:171 /go/src/github.com/caicloud/cyclone/pkg/server/router/router.go:219 /go/src/github.com/caicloud/cyclone/vendor/github.com/emicklei/go-restful/container.go:267 /go/src/github.com/caicloud/cyclone/vendor/github.com/emicklei/go-restful/filter.go:21 /go/src/github.com/caicloud/cyclone/vendor/github.com/emicklei/go-restful/options_filter.go:15 /go/src/github.com/caicloud/cyclone/vendor/github.com/emicklei/go-restful/options_filter.go:25 /go/src/github.com/caicloud/cyclone/vendor/github.com/emicklei/go-restful/filter.go:19 /go/src/github.com/caicloud/cyclone/vendor/github.com/emicklei/go-restful/cors_filter.go:40 /go/src/github.com/caicloud/cyclone/api/rest/init.go:72 /go/src/github.com/caicloud/cyclone/vendor/github.com/emicklei/go-restful/filter.go:19 /go/src/github.com/caicloud/cyclone/vendor/github.com/emicklei/go-restful/container.go:269 /go/src/github.com/caicloud/cyclone/vendor/github.com/emicklei/go-restful/container.go:120 /usr/local/go/src/net/http/server.go:1918 /usr/local/go/src/net/http/server.go:2254 /go/src/github.com/caicloud/cyclone/vendor/github.com/emicklei/go-restful/container.go:287 /usr/local/go/src/net/http/server.go:2619 /usr/local/go/src/net/http/server.go:1801 /usr/local/go/src/runtime/asm_amd64.s:2337
supereagle added a commit to supereagle/cyclone that referenced this issue Jan 25, 2018
@supereagle
fix(caicloud#330): fix panic error when abort pipeline which has no log
d612c20
@supereagle supereagle mentioned this issue Jan 25, 2018
Merged
1 task
supereagle added a commit that referenced this issue Jan 26, 2018
@supereagle
fix(#330): fix panic error when abort pipeline which has no log (#331)
7fd8f6e
supereagle added a commit to supereagle/cyclone that referenced this issue Mar 2, 2018
@supereagle
fix(caicloud#330): fix panic error when abort pipeline which has no log
fae9c7e
@supereagle supereagle mentioned this issue Mar 2, 2018
Merged
supereagle added a commit to supereagle/cyclone that referenced this issue Mar 4, 2018
@supereagle
fix(caicloud#330): fix panic error when abort pipeline which has no log
b44775b
caicloud-bot pushed a commit that referenced this issue Mar 4, 2018
@supereagle @caicloud-bot
fix(#330): fix panic error when abort pipeline which has no log (#364)
c277670 
Automatic merge from submit-queue.

Cherry pick #331 into release-0.3

**What this PR does / why we need it**:

Manually cherry pick #331 into release-0.3:
#331: fix(#330): fix panic error when abort pipeline which has no log

**Which issue(s) this PR fixes** *(optional, close the issue(s) when PR gets merged)*:

Fixes #330

**Special notes for your reviewer**:

/cc @zhujian7 

**Release note**:

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@supereagle