[cps-2.8] fix: deleting pod stuck on Terminating status #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WorkflowRun GC SHOULD Wait all workflowRun related workload pods deleting completed, then start gc pod to clean date on PV.Otherwise, if the path which is used by workload pods in the PV is deleted before workload pods deletion, the pod deletion process will get stuck on Terminating status.
If there are pods not finished and this is not the last gc try process, cyclone will not start gc pod to clean data on PV
caicloud-bot
added
the
caicloud-cla: yes
|
@caicloud-bot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the caicloud/tools repository. |
caicloud-bot
added
do-not-merge/release-note-label-needed
|
/release-note-none |
caicloud-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
caicloud-bot
added
the
approved
caicloud-bot
pushed a commit
that referenced
this pull request
Dec 17, 2019
* fix: update tenant pvc not found error (#1150) * fix: argument escape problem (#1152) * fix: resources not freed immediately after stage finished (#1157) (#1160) * fix: resources not freed immediately after stage finished * fix: remove retry config * fest: skip ssl verify for gitlab (#1166) * fix: last line log would be missing if not ended with \n (#1171) * [release-1.0] fix: assign resource requirements of cyclone containers with 0 (#1169) * fix: assign resource requirements of cyclone containers with 0 * test: add some test for apply resource requirements * fix: use mkdir to acquire lock in git resolver (#1170) * perf: improve git resolver performance with --depth (#1180) * fix: sonar qube entrypoint bug fixes (#1183) * chore: add debug logs for sonar qube image (#1182) * [release-1.0] All container logs (#1184) * feat: support all container logs stream and download * chore: add unit test for folder logs * fix: output container name * fix: add auth info when get scan results (#1185) * chore: add supported kubernetes versions (#1186) * fix: low level bug of gitlab v3 version (#1188) * chore: disable PVC watcher (#1191) * [release-1.0] fix: skip ssl verify for gitlab (#1196) * fix(kaide): skip ssl verify for gitlab * fix(kaide): skip ssl verify for gitlab again * fix(kaide): skip ssl verify for gitlab again and again * fix: github release event webhook trigger workflow twice (#1202) * fix: make dind bip configurable (#1207) * feat: make resource requirement of gc pod configurable (#1206) * fix: can not list working pods (#1224) * feat: collect realtime init container logs (#1226) * [release-1.0] feat(toolbox): add fstream tool to collect init container logs (#1227) * chore(vendor): add spf13 cobra * feat(toolbox): add fstream tool to collect init container logs * fix: workflow run status check logic (#1228) * fix(bitbucket): need response to do error check (#1232) * fix(error code): clarify error code (#1233) * chore: update gradle image version to 5.5.1 for stage template (#1229) * fix: label value for wft event repo too long (#1230) * fix(git-resolver): can not pull bitbucket code with personal access token (#1231) * fix: workflow run status check logic (#1234) * fix: set http.postBuffer for git resolver (#1225) * fix: GitLab tag deletion should not trigger workflow (#1238) * fix: bitbucket pr webhook problem (#1239) * fix: can not list gitlab branch whose project name contains dot (#1235) * [release-1.0] feat(server): support dry-run for creating integration (#1241) * feat(server): add api for integration validation * feat(server): dry-run for creating integration * fix: validate bitbucket token (#1237) * fix: gitlab version detect problem (#1236) * [release-1.0] fix(log-stream): websocket interrupted occasionally (#1242) * fix(log-stream): websocket interrupted occasionally * refactor: send log stream by websocket * fix: use error with reason for token validation fail (#1243) * feat(api): support list pull requests of scm repo (#1240) * fix: use authorization error to token validation fail (#1244) * fix: init pull request status when wfr start (#1246) * [release-1.0] fix: send notification only once (#1248) * fix: send notification only once * fix: no need to use lock for controller * fix: specify some dial tcp errors (#1255) * fix(panic): call of reflect.Value.IsNil on zero Value (#1256) * fix: git clone from bitbucket failed (#1257) * fix: defer exit to collect init containers' logs (#1258) * fix: add target branch for list pull requests api (#1259) * fix: out of range panic protection (#1261) * fix: image tag wrong when workflow triggered by bitbucket release (#1264) * [release-1.0] feat: add execution contexts api (#1267) * feat: add precheck api * feat: add list execution contexts api * fix: add Closed phase for execution context * [release-1.0] fix: GitHub tag trigger problem (#1270) * feat: support tag create event for github webhook * fix: delete release trigger for github * test: add tests for pvc watcher (#1271) * chore: add mount propagation (#1275) * [cps-2.8] fix: close websocket when workflow run running completed (#1283) * fix: close websocket when workflow run running completed * refactor: check wfr regularly to reduce cost * fix: eof of stage logs FolderReader (#1285) * fix(1292): fix out of memory of golangci-lint (#1295) * fix: reduce cpu usage caused by go ticker incorrect use (#1322) * [cps-2.8] fix: deleting pod stuck on Terminating status (#1323) * fix: deleting pod stuck on Terminating status WorkflowRun GC SHOULD Wait all workflowRun related workload pods deleting completed, then start gc pod to clean date on PV.Otherwise, if the path which is used by workload pods in the PV is deleted before workload pods deletion, the pod deletion process will get stuck on Terminating status. * fix(gc): deleting pod stuck on Terminating status If there are pods not finished and this is not the last gc try process, cyclone will not start gc pod to clean data on PV * feat(oauth): cherry-pick from v0.8 to v0.9 (#1165) * feat(oauth): cherry-pick from v0.8 to v0.9 * feat(oauth): cherry-pick from v0.8 to v0.9 * fix(oauth): fix golint * fix(oauth): delete unused code * fix(oauth): format import path * feat(oauth): cherry-pick from v0.9.5 to v0.9.7-alpha (#1209) * fix: update tenant pvc not found error (#1150) * fix: argument escape problem (#1152) * fix: resources not freed immediately after stage finished (#1157) (#1160) * fix: resources not freed immediately after stage finished * fix: remove retry config * fest: skip ssl verify for gitlab (#1166) * fix: last line log would be missing if not ended with \n (#1171) * [release-1.0] fix: assign resource requirements of cyclone containers with 0 (#1169) * fix: assign resource requirements of cyclone containers with 0 * test: add some test for apply resource requirements * fix: use mkdir to acquire lock in git resolver (#1170) * perf: improve git resolver performance with --depth (#1180) * fix: sonar qube entrypoint bug fixes (#1183) * chore: add debug logs for sonar qube image (#1182) * [release-1.0] All container logs (#1184) * feat: support all container logs stream and download * chore: add unit test for folder logs * fix: output container name * fix: add auth info when get scan results (#1185) * chore: add supported kubernetes versions (#1186) * fix: low level bug of gitlab v3 version (#1188) * chore: disable PVC watcher (#1191) * [release-1.0] fix: skip ssl verify for gitlab (#1196) * fix(kaide): skip ssl verify for gitlab * fix(kaide): skip ssl verify for gitlab again * fix(kaide): skip ssl verify for gitlab again and again
caicloud-bot
added a commit
that referenced
this pull request
Apr 16, 2020
…oem-hr-4 (#1397) * fix: update tenant pvc not found error (#1150) * fix: argument escape problem (#1152) * fix: resources not freed immediately after stage finished (#1157) (#1160) * fix: resources not freed immediately after stage finished * fix: remove retry config * fest: skip ssl verify for gitlab (#1166) * fix: last line log would be missing if not ended with \n (#1171) * [release-1.0] fix: assign resource requirements of cyclone containers with 0 (#1169) * fix: assign resource requirements of cyclone containers with 0 * test: add some test for apply resource requirements * fix: use mkdir to acquire lock in git resolver (#1170) * perf: improve git resolver performance with --depth (#1180) * fix: sonar qube entrypoint bug fixes (#1183) * chore: add debug logs for sonar qube image (#1182) * [release-1.0] All container logs (#1184) * feat: support all container logs stream and download * chore: add unit test for folder logs * fix: output container name * fix: add auth info when get scan results (#1185) * chore: add supported kubernetes versions (#1186) * fix: low level bug of gitlab v3 version (#1188) * chore: disable PVC watcher (#1191) * [release-1.0] fix: skip ssl verify for gitlab (#1196) * fix(kaide): skip ssl verify for gitlab * fix(kaide): skip ssl verify for gitlab again * fix(kaide): skip ssl verify for gitlab again and again * fix: github release event webhook trigger workflow twice (#1202) * fix: make dind bip configurable (#1207) * feat: make resource requirement of gc pod configurable (#1206) * fix: can not list working pods (#1224) * feat: collect realtime init container logs (#1226) * [release-1.0] feat(toolbox): add fstream tool to collect init container logs (#1227) * chore(vendor): add spf13 cobra * feat(toolbox): add fstream tool to collect init container logs * fix: workflow run status check logic (#1228) * fix(bitbucket): need response to do error check (#1232) * fix(error code): clarify error code (#1233) * chore: update gradle image version to 5.5.1 for stage template (#1229) * fix: label value for wft event repo too long (#1230) * fix(git-resolver): can not pull bitbucket code with personal access token (#1231) * fix: workflow run status check logic (#1234) * fix: set http.postBuffer for git resolver (#1225) * fix: GitLab tag deletion should not trigger workflow (#1238) * fix: bitbucket pr webhook problem (#1239) * fix: can not list gitlab branch whose project name contains dot (#1235) * [release-1.0] feat(server): support dry-run for creating integration (#1241) * feat(server): add api for integration validation * feat(server): dry-run for creating integration * fix: validate bitbucket token (#1237) * fix: gitlab version detect problem (#1236) * [release-1.0] fix(log-stream): websocket interrupted occasionally (#1242) * fix(log-stream): websocket interrupted occasionally * refactor: send log stream by websocket * fix: use error with reason for token validation fail (#1243) * feat(api): support list pull requests of scm repo (#1240) * fix: use authorization error to token validation fail (#1244) * fix: init pull request status when wfr start (#1246) * [release-1.0] fix: send notification only once (#1248) * fix: send notification only once * fix: no need to use lock for controller * fix: specify some dial tcp errors (#1255) * fix(panic): call of reflect.Value.IsNil on zero Value (#1256) * fix: git clone from bitbucket failed (#1257) * fix: defer exit to collect init containers' logs (#1258) * fix: add target branch for list pull requests api (#1259) * fix: out of range panic protection (#1261) * fix: image tag wrong when workflow triggered by bitbucket release (#1264) * [release-1.0] feat: add execution contexts api (#1267) * feat: add precheck api * feat: add list execution contexts api * fix: add Closed phase for execution context * [release-1.0] fix: GitHub tag trigger problem (#1270) * feat: support tag create event for github webhook * fix: delete release trigger for github * test: add tests for pvc watcher (#1271) * chore: add mount propagation (#1275) * [cps-2.8] fix: close websocket when workflow run running completed (#1283) * fix: close websocket when workflow run running completed * refactor: check wfr regularly to reduce cost * fix: eof of stage logs FolderReader (#1285) * fix(1292): fix out of memory of golangci-lint (#1295) * fix: reduce cpu usage caused by go ticker incorrect use (#1322) * [cps-2.8] fix: deleting pod stuck on Terminating status (#1323) * fix: deleting pod stuck on Terminating status WorkflowRun GC SHOULD Wait all workflowRun related workload pods deleting completed, then start gc pod to clean date on PV.Otherwise, if the path which is used by workload pods in the PV is deleted before workload pods deletion, the pod deletion process will get stuck on Terminating status. * fix(gc): deleting pod stuck on Terminating status If there are pods not finished and this is not the last gc try process, cyclone will not start gc pod to clean data on PV * fix: svn checkout with can't convert string from 'UTF-8' to native encoding (#1357) * feat(server): make qps and brust configurable for k8s client (#1359) Co-authored-by: caicloud-bot <register@caicloud.io> Co-authored-by: Jian Zhu <36154065+zhujian7@users.noreply.github.com> Co-authored-by: Jiekun Zhang <zhangjiekun@caicloud.io> Co-authored-by: De Chen <chende@caicloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1321
/assign zhujian7