feat: support sbt accelerate #1481
Conversation
caicloud-bot
added
the
release-note-none
|
Thanks for your pull request. Before we can look at your pull request, you'll need to finish a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/caicloud/engineering/blob/master/guidelines/cla.md to complete the CLA. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the caicloud/tools repository. I understand the commands that are listed here. |
caicloud-bot
added
the
caicloud-cla: no
hyy0322
changed the title
caicloud-bot
added
size/S
hyy0322
force-pushed
the
sbt-accelerate
branch
from
7f77168
to
1c51468
Compare
caicloud-bot
added
caicloud-cla: yes
hyy0322
force-pushed
the
sbt-accelerate
branch
from
1c51468
to
4741d6f
Compare
caicloud-bot
added
size/M
hyy0322
changed the title
caicloud-bot
removed
the
do-not-merge/work-in-progress
hyy0322
force-pushed
the
sbt-accelerate
branch
from
4741d6f
to
14b5c5f
Compare
| @@ -48,6 +48,9 @@ func NewAccelerator(tenant, project string, wfr *v1alpha1.WorkflowRun) *Accelera | |||
| // - '/root/.m2' maven dependency path | |||
| // - '/root/.gradle' gradle dependency path | |||
| // - '/root/.npm' npm dependency path | |||
| // - '/root/.sbt' sbt default configuration path | |||
There was a problem hiding this comment.
Is the configuration path necessary, I think the sizes of configuration files will not be very large usually.
There was a problem hiding this comment.
I was considering configure repositories in path .sbt. After some dig, I found it can be configured by sbt command line sbt -Dsbt.override.build.repos=true sbt -Dsbt.repository.config=<repositories-config-file-path>.
So, I will remove .sbt path
hyy0322
force-pushed
the
sbt-accelerate
branch
from
14b5c5f
to
599bd8d
Compare
caicloud-bot
added
size/S
hyy0322
force-pushed
the
sbt-accelerate
branch
from
599bd8d
to
cb04752
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
caicloud-bot
added
the
approved
|
/cherrypick cps-2.8 |
|
@zhujian7: once the present PR merges, I will cherry-pick it on top of cps-2.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick cps-2.10 |
|
@zhujian7: once the present PR merges, I will cherry-pick it on top of cps-2.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zhujian7: new pull request created: #1489 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zhujian7: new pull request created: #1490 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @zhujian7 @supereagle
Release note: