Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cps-2.8: feat(controllers): make resyncPeriod configurable #1520

Merged

Conversation

knight42
Copy link
Collaborator

@knight42 knight42 commented Nov 5, 2020

What this PR does / why we need it:

Make resyncPeriod configurable

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @zhujian7

Release note:

NONE

@caicloud-bot caicloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2020
@knight42 knight42 changed the title feat(controllers): make resyncPeriod configurable cps-2.8: feat(controllers): make resyncPeriod configurable Nov 5, 2020
@caicloud-bot caicloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 5, 2020
@caicloud-bot
Copy link
Collaborator

Thanks for your pull request. Before we can look at your pull request, you'll need to finish a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/caicloud/engineering/blob/master/guidelines/cla.md to complete the CLA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the caicloud/tools repository. I understand the commands that are listed here.

@caicloud-bot caicloud-bot added the caicloud-cla: no Indicates the PR's author has not signed the Caicloud CLA. label Nov 5, 2020
@caicloud-bot
Copy link
Collaborator

Thanks for your pull request. Before we can look at your pull request, you'll need to finish a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/caicloud/engineering/blob/master/guidelines/cla.md to complete the CLA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the caicloud/tools repository. I understand the commands that are listed here.

@knight42 knight42 force-pushed the feat/2.8-config-resync-period branch from 7a2cb58 to 3dea030 Compare November 5, 2020 09:52
@knight42 knight42 force-pushed the feat/2.8-config-resync-period branch from 3dea030 to 18e65f6 Compare November 5, 2020 09:54
@caicloud-bot caicloud-bot added caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. and removed caicloud-cla: no Indicates the PR's author has not signed the Caicloud CLA. labels Nov 5, 2020
@zhujian7
Copy link
Collaborator

zhujian7 commented Nov 5, 2020

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2020
@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2020
@caicloud-bot caicloud-bot merged commit 56c9019 into caicloud:cps-2.8 Nov 5, 2020
@knight42 knight42 deleted the feat/2.8-config-resync-period branch November 5, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants