Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controllers): make resyncPeriod configurable (#1519) #1521

Merged

Conversation

knight42
Copy link
Collaborator

@knight42 knight42 commented Nov 8, 2020

What this PR does / why we need it:

Manually cherry-pick 4319aaf into branch cps-2.10.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @zhujian7

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. labels Nov 8, 2020
@zhujian7
Copy link
Collaborator

zhujian7 commented Nov 8, 2020

/lgtm
/release-note-none

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2020
@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2020
@caicloud-bot caicloud-bot merged commit d382a7c into caicloud:cps-2.10 Nov 8, 2020
@knight42 knight42 deleted the feat/2.10-config-resync-period branch November 8, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants