Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to specify extra labels or annotations of pod in stage #1524

Merged
merged 3 commits into from
Nov 19, 2020

Conversation

knight42
Copy link
Collaborator

@knight42 knight42 commented Nov 19, 2020

What this PR does / why we need it:

Enable users to specify extra labels or annotations of pod in stage.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

The reason I change the apiVersion of PSP to policy/v1beta1 is the current apiVersion extensions/v1beta1 has been deprecated and will be removed in k8s v1.16: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

/cc @zhujian7

Release note:

NONE

@caicloud-bot caicloud-bot added caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2020
@caicloud-bot caicloud-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2020
@zhujian7
Copy link
Collaborator

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2020
@caicloud-bot caicloud-bot merged commit 9f27edd into caicloud:master Nov 19, 2020
@knight42 knight42 deleted the feat/pod-meta-in-stage branch November 19, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants