Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): do not update PR status if wfr is canceled automatically #1548

Merged
merged 1 commit into from Dec 31, 2020

Conversation

knight42
Copy link
Collaborator

What type of PR is this?

/kind bug
/area cicd

What this PR does / why we need it:

Do not update PR status if WorkflowRun is canceled automatically.

Complement #1541

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @zhujian7

Does this PR introduce a user-facing change?:

fix: do not update PR status if WorkflowRun is canceled automatically.

@caicloud-bot caicloud-bot added kind/bug Categorizes issue or PR as related to a bug. area/cicd Pipeline related functions. labels Dec 31, 2020
@caicloud-bot caicloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 31, 2020
@caicloud-bot caicloud-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 31, 2020
@zhujian7
Copy link
Collaborator

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 31, 2020
@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2020
@caicloud-bot caicloud-bot merged commit 13ca6ec into caicloud:master Dec 31, 2020
@knight42 knight42 deleted the feat/auto-cancel branch December 31, 2020 03:19
@knight42
Copy link
Collaborator Author

/cherrypick cps-2.10-infra
/cherrypick cps-2.10

@caicloud-bot
Copy link
Collaborator

@knight42: new pull request created: #1549

In response to this:

/cherrypick cps-2.10-infra
/cherrypick cps-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knight42
Copy link
Collaborator Author

/cherrypick cps-2.10

@caicloud-bot
Copy link
Collaborator

@knight42: new pull request created: #1550

In response to this:

/cherrypick cps-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cicd Pipeline related functions. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants