-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#346): use cache volume to speed up pipeline #347
Conversation
Can one of the admins verify this patch? |
event/event.go
Outdated
return "" | ||
} | ||
|
||
if v, e := event.Data["cachevolume"]; e { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the map key should be variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is just for release-0.3
, so keep consistent with other codes. It will not be like this in the latest implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
/lgtm |
b2fee09
to
f9d8762
Compare
f9d8762
to
c88da1d
Compare
/lgtm cancel |
/lgtm |
af37bdd
to
6640904
Compare
/lgtm cancel //PR changed after LGTM, removing LGTM. @bbbmj @supereagle |
6640904
to
028a812
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bbbmj, supereagle The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue. |
Can one of the admins verify this patch? |
What this PR does / why we need it:
Use cache volume to speed up pipeline
Which issue(s) this PR fixes (optional, close the issue(s) when PR gets merged):
Fixes #346
Special notes for your reviewer:
/cc @bbbmj
Release note: