Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#346): use cache volume to speed up pipeline #347

Merged
merged 4 commits into from
Feb 27, 2018

Conversation

supereagle
Copy link
Member

What this PR does / why we need it:

Use cache volume to speed up pipeline

Which issue(s) this PR fixes (optional, close the issue(s) when PR gets merged):

Fixes #346

Special notes for your reviewer:

/cc @bbbmj

Release note:

Cache dependency to speed up pipeline.

@caicloud-bot caicloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 16, 2018
@caicloud-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@caicloud-bot caicloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 16, 2018
event/event.go Outdated
return ""
}

if v, e := event.Data["cachevolume"]; e {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the map key should be variable?

Copy link
Member Author

@supereagle supereagle Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is just for release-0.3, so keep consistent with other codes. It will not be like this in the latest implementation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bbbmj
Copy link
Member

bbbmj commented Feb 19, 2018

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2018
@bbbmj
Copy link
Member

bbbmj commented Feb 26, 2018

/lgtm cancel

@caicloud-bot caicloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2018
@bbbmj
Copy link
Member

bbbmj commented Feb 26, 2018

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2018
@caicloud-bot
Copy link
Collaborator

/lgtm cancel //PR changed after LGTM, removing LGTM. @bbbmj @supereagle

@caicloud-bot caicloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2018
@bbbmj
Copy link
Member

bbbmj commented Feb 27, 2018

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2018
@supereagle
Copy link
Member Author

/approve

@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbbmj, supereagle

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2018
@caicloud-bot
Copy link
Collaborator

Automatic merge from submit-queue.

@caicloud-bot caicloud-bot merged commit 36002ee into caicloud:release-0.3 Feb 27, 2018
@caicloud-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@supereagle supereagle deleted the cache-volume branch March 8, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants