add test cases #52
add test cases #52
Conversation
gaocegege
force-pushed
the
add-test-cases
branch
5 times, most recently
from
06c98a1
to
c0464e6
Compare
gaocegege
force-pushed
the
add-test-cases
branch
3 times, most recently
from
d8252cf
to
c57f09d
Compare
|
I have tried to run e2e tests in travis but fails because of the time limit. |
|
PTAL @Superxi911 |
| "github.com/caicloud/cyclone/store" | ||
| "github.com/emicklei/go-restful" | ||
| docker_client "github.com/fsouza/go-dockerclient" | ||
| ) | ||
|
|
||
| const WORKER_NODE_DOCKER_VERSION = "1.10.1" | ||
| // WORKER_NODE_DOCKER_VERSION defines the required docker version in worker node. | ||
| const WORKER_NODE_DOCKER_VERSION = "WORKER_NODE_DOCKER_VERSION" |
There was a problem hiding this comment.
I think we should restrict it by code, not by ENV
There was a problem hiding this comment.
For example, if we wanna change the supported docker version in worker node, we have to re-compile the code.
It's not cool.
There was a problem hiding this comment.
If we wanna change the supported docker version in worker node in future, it means we have update our codes to support more docker version, not just modify a const string.
There was a problem hiding this comment.
I changed here because travis's docker version is 1.12.0, and this version could pass e2e tests.
There was a problem hiding this comment.
And now the default is 1.10.1, I think it would be OK.
We could add some tips in doc, for example "This is just for test."
There was a problem hiding this comment.
Ok, suggest user don't configure this ENV in doc.
| Client *docker_client.Client | ||
| Registry string | ||
| AuthConfig *AuthConfig | ||
| EndPoint string |
There was a problem hiding this comment.
Why expose these vars? We have functions to get them, such as: GetDockerAuthConfig, GetDockerRegistry. If you expose them, them can be modified
There was a problem hiding this comment.
just for test, we can not mock this manager if we don't expose them.
There was a problem hiding this comment.
Would exposed the vars violate the golang's coding style? if yes, i think can delete the functions, as GetDocker***
Signed-off-by: Ce Gao <ce.gao@outlook.com>
gaocegege
force-pushed
the
add-test-cases
branch
from
c57f09d
to
41ee996
Compare
|
PTAL |
|
LGTM |
fixes #43
Signed-off-by: Ce Gao ce.gao@outlook.com