fix: support update svn hooks #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caicloud-bot
added
release-note-none
- fix can not update svn hooks - get svn repo info by main repo url instead of svn server url
zhujian7
force-pushed
the
update-svn-hooks
branch
from
3423278
to
45c286c
Compare
|
/cc @supereagle @cd1989 |
supereagle
reviewed
Nov 20, 2018
pkg/server/manager/pipeline.go
Outdated
| gitSource, err = api.GetGitSource(pipeline.Build.Stages.CodeCheckout.MainRepo) | ||
| if err != nil { | ||
| return nil, err | ||
| createWebhook(pipeline, provider, scmConfig.Type, gitSource.Url, "") |
There was a problem hiding this comment.
Check the returned error by createWebhook()?
pkg/server/manager/pipeline.go
Outdated
| // Remove the webhook if there is error. | ||
| defer func() { | ||
| if err != nil && gitSource != nil && pipeline.AutoTrigger != nil && pipeline.AutoTrigger.SCMTrigger != nil { | ||
| //if err != nil && gitSource != nil && webHook != nil { |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: supereagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
caicloud-bot
added
the
approved
|
/cherrypick master |
|
@zhujian7: #611 failed to apply on top of branch "master": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @your-reviewer
Release note: