add parsing yaml log in caicloud.yaml ; increase more check when clone code #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaocegege
previously requested changes
Nov 24, 2016
| @@ -59,9 +59,21 @@ func insert(url, insertion string, index int) string { | |||
| func getUrlwithToken(url, subvcs, token string) string { | |||
| switch subvcs { | |||
| case api.GITHUB: | |||
| if token == "" { | |||
| log.Warn("subvcs is github, but the token is empty, there meybe exist error") | |||
There was a problem hiding this comment.
I think the log could be "Sub VCS is GitHub, but the token is empty, maybe there is an error."
| position := strings.Index(url, "github.com") | ||
| if position == -1 { | ||
| log.Warn("subvcs is github and the token is not empty, but the url dosen't contain github.com") |
There was a problem hiding this comment.
I think the log could be "Sub VCS is GitHub, but the URL doesn't contain 'github.com'"
| url = insert(url, token+"@", position) | ||
| case api.GITLAB: | ||
| if token == "" { | ||
| log.Warn("subvcs is gitlab, but the token is empty, there meybe exist error") |
superxi911-zz
dismissed
gaocegege’s stale review
xiaomuqiao has modified his codes according to your comments.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、increase the check to prevent crashes
2、set service status according event's status
3、add log info about parsing yaml