Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add latest tag for image name which dosen't have tag name #80

Merged
merged 3 commits into from
Nov 29, 2016

Conversation

xiaomuqiao
Copy link
Contributor

fix issue about pulling all tags when image name which dosen't have tag name

if err != nil {
log.Errorf("imagename parse error: %v", err)
return err
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needn't else

@gaocegege
Copy link
Contributor

There is a new dependency, I'm not sure if we should update vendor 🤔

@xiaomuqiao
Copy link
Contributor Author

the new "reference" dependency have been existed in vendor, @gaocegege

@superxi911-zz
Copy link
Contributor

LGTM

@superxi911-zz superxi911-zz merged commit b8cceb8 into caicloud:master Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants