-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remain/Remove release-related PVC when release is deleted #10
Comments
What's the difference with a
We could keep it with sufficient tooltip explanations in product to avoid misunderstanding. Does it make sense? |
@xiaoq17 ReleaseController will clean all garbages when a release is deleted except |
Are we creating volume via posting PVC to kubernetes and have it create PV for us?
Adding a switch sounds like the most flexible approach. My data shouldn't have separate meaning on what type of application I'm deploying, even for stateless apps, retaining data is beneficial for situation like cold start. |
Not all. If a user create a volume with type The main concern is that The simplest way is that |
What is the reclaim policy for PV created here?
No information provided via StatefulSetController? Sounds like we can send a patch...
This is fine if we want to deliver the feature quickly; but it's better to have a switch though.
|
I'd prefer having a switch in API and let users decide whether to keep the pvc. |
More precisely, the switch might exist in :
I prefer latter. |
+1
|
Discussed offline. All PVCs are left to Resource Center. |
We have a mechanism that we will delete
PVC
s created by chart template when release is deleted. ButStatefulSet
have an opposite mode. It remains allPVC
s created by itself.The two behaviors is divisive. So release controller should decide a consistent way to handle all
PVC
s in release.Four ways:
PVC
s when release is deleted.PVC
s and leave them toVolume Module
.Release
API.The text was updated successfully, but these errors were encountered: